Console View

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

7529fa8f9bd3...

Albert Astals Cid

aacid@kde.org

Update (C)

f07b88d7c19f...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Replace some leftover auto's with std::string

f7c9ff55c74d...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Prefer Object::getNameString() over Object::getName()
This avoids repeated, implicit strlen calls when e.g. constructing
a std::string_view parameter expected by the callee.

Use a reference to the name string when the name is used repeatedly, to
avoid the recurrent variant dispatch.

Also `==` is easier to read than !strcmp.

1b016c94585f...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Object: Avoid char* decay in Object::isName(name)

98f0be58d4fe...

Stefan Brüns

stefan.bruens@rwth-aachen.de

OutputDev: Replace const char* Marked Content tagname with const string &
As the called functions require a null-terminated string, prefer
const std::string& over std::string_view.

27f5bc0191d4...

Stefan Brüns

stefan.bruens@rwth-aachen.de

SplashState: Remove no longer used constructor

8b0e3bf8ab83...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Splash: Use delegating constructor

8571c940ea8e...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Splash: Remove aaGamma member from Splash, make it static const
This was reinitialized on SplashOutputDev::beginTransparencyGroup and
SplashOutputDev::startPage.

33d8db8c49e0...

Albert Astals Cid

aacid@kde.org

More const

3a903c5ca460...

Albert Astals Cid

aacid@kde.org

PSOutputDev::addCustomColor: take const &

0394c043bd31...

Albert Astals Cid

aacid@kde.org

A few const and move variable declarations to where they are used

e65d31ca140e...

Albert Astals Cid

aacid@kde.org

Remove two unused/unneeded virtual

57390260a446...

Albert Astals Cid

aacid@kde.org

SplashOutputDev::functionShadedFill: No need to new and delete pattern

b3d7efeec156...

Albert Astals Cid

aacid@kde.org

Splash::shadedFill take const &

0ceff53ba777...

Sune Vuorela

sune@vuorela.dk

Use string_view in PSOutputDev::writePS and drop const cast

8ae0f8e765fd...

Albert Astals Cid

aacid@kde.org

Remove Object::dictGetKey

dfe53c238037...

Albert Astals Cid

aacid@kde.org

Remove Object::dictIs

57c07988455c...

Albert Astals Cid

aacid@kde.org

less auto

ced0af6c898b...

Stefan Brüns

stefan.bruens@rwth-aachen.de

XRef: Read complete entry instead of byte-wise
The entries have a fixed size per section and an implementation-defined
size limit.

Reading each entry in one go saves the per byte virtual function call
overhead.

39a4d0a6400a...

Stefan Brüns

stefan.bruens@rwth-aachen.de

XRef: Move invariant GoffsetMax() out of loop

2be612d17be1...

Stefan Brüns

stefan.bruens@rwth-aachen.de

XRef: Avoid unecessary Object::free calls on resize
The assignment implicitly calls free on the reassigned object, which
is somewhat costly as it is a function call. Using the copy-constructor
for the placement-new has the same effect.

4ab16d992e2f...

Albert Astals Cid

aacid@kde.org

Remove runtime checks for freetype < 2.1.8
We have required a newer freetype for a long time

3d259ce90ce3...

Albert Astals Cid

aacid@kde.org

Update (C)

e3816ac340ee...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Remove no longer used Object(std::unique_ptr<GooString>) overload

9bef418f2d5c...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Avoid initializing Object from GooString::copy()
This always causes an extra temporary allocation.

8e664f1c8a82...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Prefer Object(string&&) over Object(unique_ptr<GooString>)
Using make_unique<GooString> causes an unneeded temporary allocation.

c128d4a8fa84...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Function: Use std::string in tokenizer

323a3c417ef7...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Parser: use std::string for decryptedString return

da825759f39d...

Albert Astals Cid

aacid@kde.org

Remove Object::streamGetChars

d65b2d6377f8...

Albert Astals Cid

aacid@kde.org

Remove Object::streamSetPos

7c6fd4a564e3...

Albert Astals Cid

aacid@kde.org

Make PSStack::index check for i < 0 more strict
It's what the spec actually says (and what it makes sense)

83d4364864ee...

Albert Astals Cid

aacid@kde.org

Remove Object::streamClose

dd4ee2512212...

Stefan Brüns

stefan.bruens@rwth-aachen.de

goostring_format_checker: Fix verification for non-const std::string
`pointeeType->getQualifiedNameAsString()` for std::string is
std::basic_string (notably, missing the char value_type).

c5979f4f2dbf...

Stefan Brüns

stefan.bruens@rwth-aachen.de

Reduce string -> const char* decays when string(_view) is accepted
error(...) accepts std::string as argument, only the format string has
to be adapted.

Name Objects can be constructed with a std::string_view.

9de95ea2155d...

Stefan Brüns

stefan.bruens@rwth-aachen.de

GfxFont: Use string_view for constructors

cd759de48abc...

Albert Astals Cid

aacid@kde.org

Increase version so people that track master can add ifdefs on version

b0091f08803f...

Albert Astals Cid

aacid@kde.org

poppler 26.05.0

07bf093d7833...

Albert Astals Cid

aacid@kde.org

Update (C)

e48f08b6f7a1...

Juraj Šarinay

juraj@sarinay.com

Check that the optional cetificate version is present before decoding it.
DER_GetInteger() called on an empty buffer results in PORT_Assert()
calling abort() on debug builds of NSS. By a convenient coincidence,
this has always worked on release builds with empty PORT_Assert().
In such cases DER_GetInteger() returns zero, which is the default value
of version.

f788ce550cd9...

Juraj Šarinay

juraj@sarinay.com

Drop SEC_ASN1_INLINE, it has no effect other than PORT_Assert() followed by abort() on debug builds of NSS.
SEC_ASN1_CONTEXT_SPECIFIC implies the use of a sub-template by itself
and should not be combined with SEC_ASN1_INLINE.