Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About
Login

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

08f4bca6a669...
Daeho Ro
glib: construct PopplerPage::mutex (fixes crash on macOS)
PopplerPage instances are created with g_object_new(), which only
zero-initializes the instance memory and never runs a C++ constructor
for members. Since commit e3d56a0e ("glib: add a lock in PopplerPage
to make TextPage computation thread-safe", 26.05.0) the struct gained a
std::mutex member, but poppler_page_init() was empty, leaving the mutex
as an all-zero pthread_mutex_t.

On macOS PTHREAD_MUTEX_INITIALIZER is not all-zeros, so locking a
zero-filled mutex returns EINVAL, which libc++ turns into:

    std::__1::system_error: mutex lock failed: Invalid argument

aborting every glib consumer that renders a page (e.g.
poppler_page_render_full). On glibc PTHREAD_MUTEX_INITIALIZER happens
to be all-zeros, which is why the bug is macOS-specific.

Placement-construct the mutex in poppler_page_init() and destroy it in
poppler_page_finalize().

Closes: https://gitlab.freedesktop.org/poppler/poppler/-/work_items/1743
3cae5586f6d0...
Sune Vuorela
Clean up a bit in PostScript function
246d91ff10df...
Albert Astals Cid
CI: Use an android docker image that exists
And add a dummy variable for fgetc to make android build happy
30e756693305...
Sune Vuorela
Qt: copy data to byte array, don't use after free
Fixes: #1737
21106495906e...
Sune Vuorela
Fix msvc build in XRef (missing array include)
097554169bad...
Albert Astals Cid
Remove deprecated DCT and JPX decoders
ce20cfbeea33...
Albert Astals Cid
FoFiType1C::convertToCIDType0: Fix crash on malformed files
d1700a8d3b56...
Albert Astals Cid
Update (C)
49902b86a792...
Trevor L Davis
cpp: Add render_hint::ignore_paper_color to allow transparent paper
3395bc027632...
Albert Astals Cid
Increase version so people that track master can add ifdefs on version
1fe40984214a...
Albert Astals Cid
poppler 26.06.0
a2cf35eb551f...
Albert Astals Cid
Update (C)
2f10803defbc...
Lucas Baudin
Use call_once to initialize annots list in Page instead of relying on pageLocker
The pageLocker call was introduced in 4aca25d63d11186846641100d8cd964cf818845a, but it turns out it is
not correct as annotations may themselves call Page::getAnnots to check that their appearance stream
can be safely removed. However, there is no possible race in this case since the annots list
must have been loaded already.
7e23e8139161...
Albert Astals Cid
Page::getAnnots: Remove unused parameter
Also it did not make sense because we're caching annots so querying with
a different xref would not produce a different result as one would
possibly expect
e307fc8ed2d9...
Albert Astals Cid
Update (C)
835226476665...
Marek Kasik
SplashOutputDev: Fix integer overflow in tilingPatternFill
Use checkedMultiply() to check integer multiplication of surface size
and number of repetitions to avoid integer overflow and possible memory issues.

Fixes: #1715
0247268f6451...
Sune Vuorela
certificate der is binary data; don't use string
  • runtests: updating docs -  stdio
5d5f1f6aebc8...
Sune Vuorela
Use std::chrono for cert validity
Also fix 32bit signed time issue with gpgme api.
d50a4510de48...
Albert Astals Cid
Some const PDFRectangle * to const PDFRectangle &
0f94f530852b...
Albert Astals Cid
Some const GfxColor * to const GfxColor &
83ab29cbce91...
Albert Astals Cid
Functions with 0 inputs are not valid
690e8232ab83...
Albert Astals Cid
More std::string
da155125f201...
Albert Astals Cid
Annot: Make a bunch of functions return const * instead of *
00f52285ec61...
Albert Astals Cid
Annot: A few * parameters to const &
5c2d7896f2f0...
Albert Astals Cid
Annot: add some const markers to functions
620b426507c8...
Albert Astals Cid
Annot:  Change pointers we always use without checking for null to references
e1a4f1cfb8e4...
Albert Astals Cid
More std::string
7e192687c899...
Albert Astals Cid
Convert choices to vector
b4a64f349cee...
Albert Astals Cid
Convert defaultChoices to vector
deafdd361d90...
Albert Astals Cid
FormFieldChoice::getNumSelected() is const
373db7b2e13c...
Albert Astals Cid
Convert contents to GooString
It was never a null pointer.

There is a bit of speed lost in copying strings in SetContent, but
that's far from a hot path so the clarity of knowing getContent returns
a valid object is worth it
9e6976cdf862...
Albert Astals Cid
HorizontalTextLayouter take const &
2cc46515b4d6...
Albert Astals Cid
Take const std::string & as parameter
6b96e3fa5914...
Albert Astals Cid
PSSubstFont::psName can be a std::string
5984cbfdef39...
Albert Astals Cid
Take const std::string & instead of const char *
d4f70896193b...
Albert Astals Cid
embFontList is a std::string so add strings instead of char*
dc7e5d2f4b2f...
Albert Astals Cid
Remove unneeded const_cast
bd259f220507...
Albert Astals Cid
One unique_ptr more
2e7a6cf54cc0...
Albert Astals Cid
Turn a few GooString to std::string and save a new/delete
efec9f8c32a4...
Albert Astals Cid
Convert 4 const char * to const std::string